Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with new Storybook 4.0+ #1260

Closed
skaraman opened this issue Nov 30, 2018 · 3 comments
Closed

Incompatible with new Storybook 4.0+ #1260

skaraman opened this issue Nov 30, 2018 · 3 comments

Comments

@skaraman
Copy link

storybookjs/storybook#4796

Storybook requires a module called emotion which imports createContext from react

When we use preact, this module throws an error because the preact-compat mapping for createContext over to preact for imports from 'react' is not compatible with the new Storybook version

Any chance this will be fixed?

@BartWaardenburg
Copy link

BartWaardenburg commented Dec 2, 2018

Hey @skaraman, I'm working on a specific @storybook/preact version so we no longer have to patch the storybook runtime with preact-compat. I hope to have it finished in the coming days.

Edit: I opened the pull request with storybook: storybookjs/storybook#4912

@developit
Copy link
Member

@BartWaardenburg feel free to drop a message into the preact slack chat if you run into anything or are looking for help!

@skaraman
Copy link
Author

skaraman commented Jan 9, 2019

This issue has been resolved with recent versions of Storybook (I'm using 4.1.4).

FYI, some add-ons do not support Preact like "Add-Info" and must be uninstalled and removed from story.jsx files

@skaraman skaraman closed this as completed Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants