From 924ab51965bd4d55f6f3320d94677d99ecca1dcf Mon Sep 17 00:00:00 2001 From: Ryan Christian Date: Wed, 21 Dec 2022 16:51:13 -0600 Subject: [PATCH 1/3] fix: Correct `--esm` not being enabled by default in prod --- packages/cli/src/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/cli/src/index.js b/packages/cli/src/index.js index 55d401a17..9773a06ba 100755 --- a/packages/cli/src/index.js +++ b/packages/cli/src/index.js @@ -37,7 +37,7 @@ prog .option('--src', 'Specify source directory', 'src') .option('--dest', 'Specify output directory', 'build') .option('--cwd', 'A directory to use instead of $PWD', '.') - .option('--esm', 'Builds ES-2015 bundles for your code', false) + .option('--esm', 'Builds ES-2015 bundles for your code', true) .option('--sw', 'Generate and attach a Service Worker', true) .option('--babelConfig', 'Path to custom Babel config', '.babelrc') .option('--json', 'Generate build stats for bundle analysis', false) From f11cb2dbd14ab753a9ed5b50169d75568ba9a3f4 Mon Sep 17 00:00:00 2001 From: Ryan Christian Date: Wed, 21 Dec 2022 16:51:46 -0600 Subject: [PATCH 2/3] fix: `--brotli` overwriting existing assets --- packages/cli/src/lib/webpack/webpack-client-config.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/cli/src/lib/webpack/webpack-client-config.js b/packages/cli/src/lib/webpack/webpack-client-config.js index df66951b7..a09383fe7 100644 --- a/packages/cli/src/lib/webpack/webpack-client-config.js +++ b/packages/cli/src/lib/webpack/webpack-client-config.js @@ -273,7 +273,7 @@ function isProd(env) { if (env.brotli) { prodConfig.plugins.push( new CompressionPlugin({ - filename: '[path].br[query]', + filename: '[path][base].br[query]', algorithm: 'brotliCompress', test: /\.esm\.js$/, }) From 57e6494c56bfe241e37685b0c59e25fac1a17fb4 Mon Sep 17 00:00:00 2001 From: Ryan Christian Date: Wed, 21 Dec 2022 16:54:23 -0600 Subject: [PATCH 3/3] docs: Adding changeset --- .changeset/quiet-wombats-ring.md | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 .changeset/quiet-wombats-ring.md diff --git a/.changeset/quiet-wombats-ring.md b/.changeset/quiet-wombats-ring.md new file mode 100644 index 000000000..753ad2081 --- /dev/null +++ b/.changeset/quiet-wombats-ring.md @@ -0,0 +1,7 @@ +--- +'preact-cli': patch +--- + +Fixed bug in which `--esm` was not enabled by default for production builds on v3.4.2 + +Fix for `--brotli` overwriting assets