From 61985fc204f63a66537ae4585c9d279b91280c9c Mon Sep 17 00:00:00 2001 From: Ryan Christian Date: Tue, 16 Aug 2022 05:27:14 -0500 Subject: [PATCH 1/3] fix: CSS in push-manifest was labeled as a script --- packages/cli/lib/lib/webpack/create-load-manifest.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/cli/lib/lib/webpack/create-load-manifest.js b/packages/cli/lib/lib/webpack/create-load-manifest.js index 948ee24d8..534b340e9 100644 --- a/packages/cli/lib/lib/webpack/create-load-manifest.js +++ b/packages/cli/lib/lib/webpack/create-load-manifest.js @@ -41,7 +41,7 @@ module.exports = (assets, namedChunkGroups, isProd) => { const routeJs = assets[`${route}.js`]; routeManifest[routeJs] = { type: 'script', weight: 0.9 }; - if (routeCss) routeManifest[routeCss] = { type: 'script', weight: 0.9 }; + if (routeCss) routeManifest[routeCss] = { type: 'style', weight: 0.9 }; const path = route.replace(/^route-/, '/').replace(/^\/home/, '/'); From 5d0d827081d4795d40429ce875c0457b71ea3c36 Mon Sep 17 00:00:00 2001 From: Ryan Christian Date: Tue, 16 Aug 2022 05:28:05 -0500 Subject: [PATCH 2/3] docs: Adding changeset --- .changeset/shy-poets-sneeze.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/shy-poets-sneeze.md diff --git a/.changeset/shy-poets-sneeze.md b/.changeset/shy-poets-sneeze.md new file mode 100644 index 000000000..13858d62a --- /dev/null +++ b/.changeset/shy-poets-sneeze.md @@ -0,0 +1,5 @@ +--- +'preact-cli': patch +--- + +Fix for CSS assets sometimes being mistakenly labeled as 'scripts' in the push-manifest. From 4b2ec87999bdc66ba183df3d388d0a305b204260 Mon Sep 17 00:00:00 2001 From: Ryan Christian Date: Tue, 16 Aug 2022 05:57:12 -0500 Subject: [PATCH 3/3] refactor: Skips over already set file attrs when generating push-manifest --- packages/cli/lib/lib/webpack/create-load-manifest.js | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/cli/lib/lib/webpack/create-load-manifest.js b/packages/cli/lib/lib/webpack/create-load-manifest.js index 534b340e9..0772f1b9a 100644 --- a/packages/cli/lib/lib/webpack/create-load-manifest.js +++ b/packages/cli/lib/lib/webpack/create-load-manifest.js @@ -52,6 +52,7 @@ module.exports = (assets, namedChunkGroups, isProd) => { asyncFiles.chunks.forEach(asset => { asset.files = asset.files || []; asset.files.forEach(file => { + if (routeManifest[file]) return; if (/\.css$/.test(file)) { routeManifest[file] = { type: 'style', weight: 0.9 }; } else if (/\.js$/.test(file)) {