Linter configuration errors (typescript template)

[obasille]

What is the current behaviour?
Linter failing to run.

Steps to Reproduce
Steps to reproduce the behavior:

npx preact-cli create typescript myproject
cd myproject
npm i
npm run lint

I'm getting:

Oops! Something went wrong! :(

ESLint: 6.8.0.

No files matching the pattern "'src/**/*.{js,jsx,ts,tsx}'" were found.

But then, running "eslint ." gives another error:

Oops! Something went wrong! :(

ESLint: 6.8.0.

ESLint couldn't find the plugin "eslint-plugin-jest".

Both installing the latest eslint-plugin-jest or version 25.7.0 (which is the one I got inside eslint-config-preact) fail because of dependency conflicts.

Thanks for your help!

Please mention any other relevant information

Environment Info:
  System:
    OS: Windows 10 10.0.19043
  Binaries:
    Node: 16.14.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.15 - C:\Program Files\nodejs\yarn.CMD
    npm: 8.5.4 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Chrome: 103.0.5060.114
    Edge: Spartan (44.19041.1266.0), Chromium (103.0.1264.49)
  npmPackages:
    preact: ^10.3.1 => 10.10.0
    preact-cli: ^3.0.0 => 3.4.0
    preact-render-to-string: ^5.1.4 => 5.2.1
    preact-router: ^3.2.1 => 3.2.1

[rschristian]

I'm getting:

Oops! Something went wrong! :(

ESLint: 6.8.0.

No files matching the pattern "'src/**/*.{js,jsx,ts,tsx}'" were found.

Hm, odd. There most certainly are files matching that pattern, and I can't reproduce.

But then, running "eslint ." gives another error:

Oops! Something went wrong! :(

ESLint: 6.8.0.

ESLint couldn't find the plugin "eslint-plugin-jest".

Duplicate of preactjs-templates/typescript#67

I have no idea what causes this, as eslint-pluin-jest is labeled as a dependency of the preact config. Why this only happens for that specific dependency is beyond me.

[obasille]

That’s interesting that you can’t reproduce that issue. Are you on Windows too? As a comparison I’ll try on a Mac next week.

[rschristian]

No, Linux.

Regardless, there's nothing actionable here for preact-cli, so I'm going to close this out. If you ever track down the problem you can open an issue on the template(s), the ESLint config, ESLint or NPM themselves, wherever it fits.

All I can do at the moment is point out the file patterns are correct and the eslint config does list the jest plugin as a dependency.

[obasille]

Hi @rschristian,

I did a bit of digging and found more info about this issue which I wanted to share with you and anyone stumbling on the same errors. The problem with eslint pattern error is Windows specific, arguments in single quotes just don't work.
See this issue discussed on eslint project.

A solution is to replace the single quotes by double quotes (with an escape character):
"lint": "eslint \"src/**/*.{js,jsx,ts,tsx}\"",

For the eslint-plugin-jest error, I've installed version 25.7 (the one that comes with the preact eslint plugin) while forcing npm to ignore legacy dependencies. It's working fine so far.
npm install eslint-plugin-jest@25.7 --legacy-peer-deps --save-dev

I've posted a comment on the issue you mentioned.

[rschristian]

Ugh, goddamit Windows.

Thanks! I'll try to push out that fix to the templates later today.

That peer dep issue (which I see now, thanks!) is rather annoying. Really don't want to have to continually update the templates just to satisfy a linter of all things, though might just be able to rip out @typescript-eslint/eslint-plugin and let the Jest plugin install whatever version it needs.

Will have to consider ripping out ESLint entirely and leaving it up to users to configure as they wish.

[rschristian]

Both issues should be fixed as of preactjs-templates/typescript#74

[obasille]

Just tried it and it works like a charm, thank you @rschristian!

[rschristian]

Yay! Thanks so much for tracking those issues down!