Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removes PNP CI as it only gets in the way #1694

Merged
merged 1 commit into from Jun 6, 2022

Conversation

rschristian
Copy link
Member

What kind of change does this PR introduce?

CI Chore

Did you add tests for your changes?

N/A

Summary

Blocking our PRs for upstream non-issues frankly isn't productive. It makes no sense to block work here because eslint-config-preact has specified a peer dep in a way that will trip only PNP in strict mode.

Not our problem.

@rschristian rschristian requested a review from a team as a code owner May 16, 2022 06:54
@changeset-bot
Copy link

changeset-bot bot commented May 16, 2022

⚠️ No Changeset found

Latest commit: 8469a8e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rschristian rschristian merged commit 78d81f8 into master Jun 6, 2022
@rschristian rschristian deleted the chore/remove-pnp-ci branch June 6, 2022 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants