Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump deps #1693

Merged
merged 4 commits into from Jun 6, 2022
Merged

chore: Bump deps #1693

merged 4 commits into from Jun 6, 2022

Conversation

rschristian
Copy link
Member

What kind of change does this PR introduce?

Chore

Did you add tests for your changes?

Existing cover and were updated

Summary

Bumps deps. More lock file line additions than removals is a bit disappointing. Was hoping (maybe foolishly) the opposite would happen.

Nothing user-facing saw a major bump.

Does this PR introduce a breaking change?

No

@rschristian rschristian requested a review from a team as a code owner May 16, 2022 06:37
@changeset-bot
Copy link

changeset-bot bot commented May 16, 2022

🦋 Changeset detected

Latest commit: a694571

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
preact-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

});
exports['default-esm'] = Object.assign({}, exports.default, {
'bundle.*.esm.js': 21135,
'bundle.*.esm.js.map': 111771,
'polyfills.*.esm.js': 5721,
'polyfills.*.esm.js.map': 21633,
'route-home.chunk.3cec8.js.map': 483,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Silly copy/paste error that snuck in.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be a wildcard?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The next line is the (correct) wildcard match:

'route-home.chunk.3cec8.js.map': 483,
'route-home.chunk.*.esm.js': 316,

This was a non-esm entry that somehow snuck into the esm file list, only jumped out as the file hash changed

@rschristian rschristian changed the title Chore/bump deps chore: Bump deps May 16, 2022
@rschristian rschristian merged commit 6385ec1 into master Jun 6, 2022
@rschristian rschristian deleted the chore/bump-deps branch June 6, 2022 03:05
@preact-bot preact-bot mentioned this pull request Jun 6, 2022
@merceyz
Copy link
Contributor

merceyz commented Nov 11, 2022

pnp-test@workspace:. provides eslint (p77961) with version 6.8.0, which doesn't satisfy what eslint-config-preact and some of its descendants request

sigh CI failure due to Yarn PNP not being provided some specific (but usable) version of ESLint.

The logs have expired by now but the message you quoted is a warning and doesn't impact the runtime.

It serves no purpose besides being a canary that the 5 Yarn PNP users might have issues.

Ouch.

@rschristian
Copy link
Member Author

The logs have expired by now but the message you quoted is a warning and doesn't impact the runtime.

It was the CI that you had set up, which treated that as an error and would fail the job.

It serves no purpose besides being a canary that the 5 Yarn PNP users might have issues.

Ouch.

I was referring to our users (of which I counted ~5), rather than Yarn PNP users in general, who were spotting the Yarn PNP issues.

I apologize for not being the kindest, but Yarn 2+, PNP included, has been some of the most frustrating software I've ever had to work around and this PR came after a long day of dealing with its issues.

I'll delete that comment though, it's inappropriate to keep around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants