Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove lint warnings, update tests and rename file #1691

Merged
merged 5 commits into from May 9, 2022
Merged

fix: remove lint warnings, update tests and rename file #1691

merged 5 commits into from May 9, 2022

Conversation

zubhav
Copy link
Contributor

@zubhav zubhav commented May 9, 2022

What kind of change does this PR introduce?
Tidy-up/fixes

Summary

  • Removes ESLint warnings that appear in CI
  • Rename consants to constants in filename
  • Remove unused file (TBC)

166890080-38cc2aa7-b70e-4897-ba87-ceab322b4fb2

@zubhav zubhav requested a review from a team as a code owner May 9, 2022 10:35
@changeset-bot
Copy link

changeset-bot bot commented May 9, 2022 •
edited

⚠️ No Changeset found

Latest commit: f24fd93

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

zubhav
zubhav commented May 9, 2022
View reviewed changes
packages/cli/babel/index.js Outdated Show resolved Hide resolved
rschristian
rschristian approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@rschristian rschristian enabled auto-merge (squash) May 9, 2022 21:50
@rschristian rschristian merged commit 49bba04 into preactjs:master May 9, 2022
@zubhav zubhav deleted the fix/lint-warnings-filenames branch May 10, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rschristian rschristian rschristian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zubhav @rschristian