Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable optional-chaining & nullish-coalescing in preset-env #1033

Closed
reznord opened this issue Mar 5, 2020 · 3 comments
Closed

Enable optional-chaining & nullish-coalescing in preset-env #1033

reznord opened this issue Mar 5, 2020 · 3 comments
Assignees
Milestone

Comments

@reznord
Copy link
Member

reznord commented Mar 5, 2020

Do you want to request a feature or report a bug?
Feature

What is the expected behaviour?
Support babel stage 3 features in preact-cli

If this is a feature request, what is motivation or use case for changing the behaviour?
Right now, we can use optional-chaining with preact-cl@rc since we don't support them in our babel config.

Please mention other relevant information.
By setting shippedProposals to true, we can use the following proposals in CLI

@reznord reznord added this to the 3.0 milestone Mar 5, 2020
@reznord reznord self-assigned this Mar 5, 2020
@reznord reznord added this to To do in Preact-cli 3.0 Mar 5, 2020
@reznord
Copy link
Member Author

reznord commented Mar 5, 2020

In current babel versions, shippedProposals defaults to true. But since we use preset-modules for generating esm build, we need to wait until next version of preset-env is released (after this PR is merged).

@eugenezastrogin
Copy link

PR in question seems to be merged quite some time ago.

@reznord
Copy link
Member Author

reznord commented Jun 9, 2020

This is fixed in 3.0.0-rc.14 with babel updates.

@reznord reznord closed this as completed Jun 9, 2020
@reznord reznord moved this from To do to Done in Preact-cli 3.0 Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

2 participants