Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue running pre-commit when specifying an array of types? #707

Closed
magicmark opened this issue Feb 21, 2018 · 1 comment
Closed

Issue running pre-commit when specifying an array of types? #707

magicmark opened this issue Feb 21, 2018 · 1 comment
Labels

Comments

@magicmark
Copy link
Contributor

magicmark commented Feb 21, 2018

Consider the following config:

repos:
-   repo: https://github.com/prettier/prettier
    sha: 1.10.2
    hooks:
    -   id: prettier
        name: prettier (markdown)
        files: ''
        types: [markdown]
    -   id: prettier
        name: prettier (javascript + markdown)
        files: ''
        types: [javascript, markdown]

Only the first hook matches anything. The second hook does not:

╔═ mark@mark: ~/vpg/repro git:(master) virtualenv:(venv)
╚═ ♪ pre-commit run -a
prettier (markdown)......................................................Failed
hookid: prettier

Files were modified by this hook. Additional output:

README.md 134ms

prettier (javascript + markdown).....................(no files to check)Skipped

(Full repro: https://github.com/magicmark/pre-commit-issue-repro)

Am I doing something wrong in the second example?

Thanks!

@asottile
Copy link
Member

Same misunderstanding as in #706

Please see the comment here: #706 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants