Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

respect aliases in SKIP when installing environments #2480

Merged
merged 1 commit into from Aug 11, 2022
Merged

respect aliases in SKIP when installing environments #2480

merged 1 commit into from Aug 11, 2022

Conversation

kmARC
Copy link
Contributor

@kmARC kmARC commented Aug 11, 2022

Fixes #2478

@asottile
Copy link
Member

augh the company account is even worse because I can't fix the branch at all!

asottile
asottile approved these changes Aug 11, 2022
View reviewed changes
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile asottile merged commit 6740a17 into pre-commit:main Aug 11, 2022
@kmARC
Copy link
Contributor Author

kmARC commented Aug 12, 2022 •
edited

augh the company account is even worse because I can't fix the branch at all!

Hmmm... I'm not sure what do you mean by that.

I'm planning another PR that helps a lot with monorepos, but that would also come from the company account. Do you have any guideline on how to make it easier for you?

@asottile
Copy link
Member

(1) please do not send feature PRs without first discussing them -- monorepos have been a hot topic and I have already set my expectations that there will not be special support for them

(2) when you make PRs from organizations I cannot fixup the branch like I can with user accounts

@kmARC
Copy link
Contributor Author

kmARC commented Aug 12, 2022

(1)
Understood. Our patch is not monorepo-specific, just happens to help with them a lot. I'll open an issue first to discuss.

(2)
Ah, that's quite unfortunate...

@asottile
Copy link
Member

and for (1) make sure to search around first -- I'm almost certain it's about cd and there's several discussions about this already

@kmARC kmARC mentioned this pull request Aug 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asottile asottile asottile approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SKIP skips invocation by alias but doesn't skip "Installing environment"
2 participants
@kmARC @asottile