Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch pty use to fix solaris #2390

Merged
merged 1 commit into from May 14, 2022
Merged

Switch pty use to fix solaris #2390

merged 1 commit into from May 14, 2022

Conversation

gaige
Copy link
Contributor

@gaige gaige commented May 14, 2022 •
edited

Use the child instead of parent fd when manipulating pty for color.

Fixes #2389

@gaige
Switch pty use to fix solaris
a84136d 
Use the child instead of parent fd when manipulating pty for color.
@gaige
Copy link
Contributor Author

gaige commented May 14, 2022 •
edited

Making my way through the tests here.

  • SmartOS (Solaris)
  • macOS
  • Ubuntu

@gaige gaige marked this pull request as ready for review May 14, 2022 11:09
asottile
asottile approved these changes May 14, 2022
View reviewed changes
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile asottile merged commit 9eccd9c into pre-commit:main May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asottile asottile asottile approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pre-commit hooks having execution problems on solaris (smartos)
2 participants
@gaige @asottile