Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ruby-build to latest available (v20220324) #2319

Merged
merged 1 commit into from Mar 31, 2022
Merged

Update ruby-build to latest available (v20220324) #2319

merged 1 commit into from Mar 31, 2022

Conversation

jalessio
Copy link
Contributor

@jalessio jalessio commented Mar 31, 2022 •
edited

Similar to PRs #1913 and #2205, updates ruby-build to the latest release which makes more recent versions of Ruby available to pre-commit.

Files were generated by running ./testing/make-archives.

ruby-build 20220324

https://github.com/rbenv/ruby-build/releases/tag/v20220324

@jalessio jalessio force-pushed the jamie/upgrade-rbenv-and-ruby-build branch from 58bc926 to 4a80da8 Compare March 31, 2022 17:33
@jalessio jalessio changed the title Update rbenv / ruby-build to latest available Update ruby-build to latest available Mar 31, 2022
@jalessio jalessio changed the title Update ruby-build to latest available Update ruby-build to latest available (v20220324) Mar 31, 2022
@asottile asottile force-pushed the jamie/upgrade-rbenv-and-ruby-build branch from 4a80da8 to 9021fa1 Compare March 31, 2022 18:05
@asottile
Copy link
Member

weird, something changed in either gzip or tarfile which makes a different reproducible tar on python3.9 or python3.10 -- I just regenerated using python3.8 to eliminate the diffs

asottile
asottile approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile
Copy link
Member

apparently this is the change in cpython that causes a different output -- for now I'm going to continue generating these using python3.8 but later in april I'll switch them to the 3.10 generation: python/cpython@674935b

@jalessio
Copy link
Contributor Author

apparently this is the change in cpython that causes a different output -- for now I'm going to continue generating these using python3.8 but later in april I'll switch them to the 3.10 generation: python/cpython@674935b

Oh, interesting. I recall having a discussion about "reproducible builds" which you landed in PR #1915 so I was a bit surprised to see that I generated a diff in the files I generated. Nice find on the related Python changes!

@asottile asottile merged commit 934afb8 into pre-commit:main Mar 31, 2022
@jalessio jalessio mentioned this pull request Apr 13, 2022
Merged
@jalessio jalessio mentioned this pull request Jan 21, 2023
Merged
@jalessio jalessio mentioned this pull request Apr 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asottile asottile asottile approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jalessio @asottile