Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick a tag if multiple tags exist on a SHA. #2312

Merged
merged 1 commit into from Mar 31, 2022

Conversation

mblayman
Copy link
Contributor

This PR uses git tag --points-at to check if multiple tags exist for a given tag. If so, it tries to pick the "best" one that looks like a version tag.

Fixes #2311

Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, a few small things I missed in first pass review from my phone 🙃

pre_commit/commands/autoupdate.py Outdated Show resolved Hide resolved
pre_commit/commands/autoupdate.py Outdated Show resolved Hide resolved
pre_commit/commands/autoupdate.py Outdated Show resolved Hide resolved
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile asottile merged commit b97bb18 into pre-commit:main Mar 31, 2022
@mblayman mblayman deleted the multiple-tags branch March 31, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

tags_only autoupdate picks first (alphabetical?) tag when multiple on SHA
2 participants