Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid build-time dependencies by prioritising binary over source dependencies for R #2277

Merged
merged 1 commit into from Mar 5, 2022

Conversation

lorenzwalthert
Copy link
Contributor

@lorenzwalthert lorenzwalthert commented Mar 5, 2022

This fixes the windows build for this repo.

Fixes the failing R build as discussed in #2272 (comment) by never installing R packages from source. This may create problems if no binary is available for a platform, as the common CRAN mirrors only provide binaries for macOS, Windows and popular Linux distributions.

If that's a problem, my PR could be altered to try a source installations after a binary installation failed, with some additional complexity that can't be easily tested in the R code that is provided as string here. I am not sure what platforms are officially supported here.

@asottile asottile merged commit 2ed0eaa into pre-commit:master Mar 5, 2022
@lorenzwalthert lorenzwalthert deleted the always-binary branch March 6, 2022 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants