Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GIT_HTTP_PROXY_AUTHMETHOD to kept environment variables #2271

Closed
VincentBerthier opened this issue Mar 4, 2022 · 2 comments · Fixed by #2272
Closed

Add GIT_HTTP_PROXY_AUTHMETHOD to kept environment variables #2271

VincentBerthier opened this issue Mar 4, 2022 · 2 comments · Fixed by #2272

Comments

@VincentBerthier
Copy link
Contributor

describe your issue

On the cluster I work on, there’s a proxy. It’s… Let’s just say that proxy is being a pain, and to make it work we have to set the environment variable GIT_HTTP_PROXY_AUTHMETHOD.

In pre_commit/git.py however, only a small subset of variables are kept, and that one is not among them. So, sure, I can (and did) edit the script to keep that one too (and it works now) but it’s not ideal.

pre-commit --version

pre-commit 2.17.0

.pre-commit-config.yaml

Not relevant

~/.cache/pre-commit/pre-commit.log (if present)

No response

@asottile
Copy link
Member

asottile commented Mar 4, 2022

sounds fine! would you like to send a PR?

@VincentBerthier
Copy link
Contributor Author

Sure, it’s done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants