Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More on warnings for regular expressions #2151

Closed
sanjioh opened this issue Dec 2, 2021 · 0 comments · Fixed by #2154
Closed

More on warnings for regular expressions #2151

sanjioh opened this issue Dec 2, 2021 · 0 comments · Fixed by #2154
Labels
good-first-issue

Comments

@sanjioh
Copy link

sanjioh commented Dec 2, 2021 •
edited

Hi!

As briefly discussed here:
#2053 (comment)

pre-commit could detect the [\\/] regular expression as well.
As of now (pre-commit 2.16.0), such a regex does not trigger any warnings.

Besides, IIRC, the regex [\/], currently detected, matches the single character / (not / and \), so I think it shouldn't be mentioned as an erroneous way for matching both kinds of slashes.
(see https://regex101.com/r/FRPiLZ/1)

Thanks!
@sanjioh sanjioh changed the title More warnings for regular expressions More on warnings for regular expressions Dec 2, 2021
tonyrla added a commit to tonyrla/pre-commit that referenced this issue Dec 4, 2021
@tonyrla
fix: Add missing warning for regular expression with [\\/] resolves p…
824bfd1 
…re-commit#2151

test: Testcases for said regular expression

refactor: for-loop for regex warnings instead of multiple if-clauses
tonyrla added a commit to tonyrla/pre-commit that referenced this issue Dec 4, 2021
@tonyrla
fix: Add missing warning for regular expression with [\\/]
ab377c1 
test: Testcases for said regular expression

refactor: for-loop for regex warnings instead of multiple if-clauses

resolves pre-commit#2151
tonyrla added a commit to tonyrla/pre-commit that referenced this issue Dec 4, 2021
@tonyrla
fix: Add missing warning for regular expression with [\\/]
d4ffa5b 
test: Test case parameters for said regular expression

refactor: For-loop for regex warnings instead of multiple if statements

resolves pre-commit#2151
@tonyrla tonyrla mentioned this issue Dec 4, 2021
Merged
estebanz01 pushed a commit to avlos/pre-commit that referenced this issue Dec 27, 2021
@tonyrla @estebanz01
fix: Add missing warning for regular expression with [\\/]
597726f 
test: Test case parameters for said regular expression

refactor: For-loop for regex warnings instead of multiple if statements

resolves pre-commit#2151
estebanz01 pushed a commit to avlos/pre-commit that referenced this issue Dec 27, 2021
@tonyrla @estebanz01
fix: Add missing warning for regular expression with [\\/]
6f802bf 
test: Test case parameters for said regular expression

refactor: For-loop for regex warnings instead of multiple if statements

resolves pre-commit#2151
saravankrish pushed a commit to saravankrish/pre-commit that referenced this issue Jul 7, 2023
@tonyrla @saravankrish
fix: Add missing warning for regular expression with [\\/]
4c8a309 
test: Test case parameters for said regular expression

refactor: For-loop for regex warnings instead of multiple if statements

resolves pre-commit#2151
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Add missing warning for regular expression with [\\/] tonyrla/pre-commit
2 participants
@asottile @sanjioh