check-useless-excludes meta hook doesn't seem to work well with broken symlinks

[pkoch]

Repro steps

1. Add a submodule
2. Add a symlink to somewhere inside this submodule
3. Use check-symlinks
4. Deinit submodule (to simulate the case when people clone without --recursive)
5. Notice that it now complains about the symlink created on 2
6. Add an exclude entry with the path to that symlink
7. Use check-useless-excludes
8. Notice that it complains that the added exclude entry doesn't apply.

For a working example, check out https://github.com/pkoch/test-check-useless-excludes (without --recursive, or run git submodule deinit --all) and run pre-commit run --all.

[asottile]

hmm indeed -- the "test" hook gets initialized with types: [file] which filters out the symlink -- the fix needs to happen here -- notably it should probably have a hook.setdefault('types', []) ? something like that?

[pkoch]

Unsure, can't really reason about the code. However, I can add that adding types: [] to check-useless-excludes doesn't help.

[pkoch]

Interesting! Any clues on why adding types: [] on my side didn't help?

[asottile]

my guess is you added it to the wrong thing, but you don't actually want that at runtime anyway

…

On Tue, Aug 31, 2021, 10:23 AM Paulo Köch ***@***.***> wrote: Interesting! Any clues on why adding types: [] on my side didn't help? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#2019 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAN2BHYVDNFD5DHVXNMQ4GLT7TQVDANCNFSM5CTO27LA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.