New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker inspect fails when running with Docker in Docker #1978
Comments
I believe this is already fixed by #1919 |
Thanks, so just need to wait for the next release :) |
Looking closer at those changes the |
@robin-moss why? |
@asottile Job container is the place where pre-commit is run. |
can you provide commands I can run to validate? |
@asottile I prepared test repository: https://github.com/wiget/pre-commit-in-gitlab-with-dind docker-compose up -d docker
docker-compose up --build job You can tweak |
can you reproduce without docker compose? I'd rather not use it if I don't need to |
Sure. I added few scripts. |
Thanks :) |
When trying to run pre commits with
docker_image
language via GitLabs Docker in Docker approach the docker inspect fails, and so pre-commit throws an error when trying to get the mount path.The code for this already has a fall back of "return path" but doesn't handle the docker command failing.
Could the code for this be modified to handle the docker inspect failing?
More details of docker in docker are here
Full logs of the failure:
version information
error information
The text was updated successfully, but these errors were encountered: