Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rbenv / ruby-build #1913

Merged
merged 1 commit into from May 18, 2021
Merged

Conversation

jalessio
Copy link
Contributor

@jalessio jalessio commented May 15, 2021

Similar to PR #1614, updates rbenv and ruby-build to their latest releases which makes more recent versions of Ruby available to pre-commit.

rbenv

Doesn't look like rbenv has any recent tags (latest is from March 25, 2019), so this is current HEAD of master branch:
rbenv/rbenv@585ed84

ruby-build 20210510

https://github.com/rbenv/ruby-build/releases/tag/v20210510

@jalessio
Copy link
Contributor Author

jalessio commented May 15, 2021

@asottile per your mention about "reproducible builds" for the tar.gz files it could be accomplished in a Github-specific way by updating make-archives to grab the URLs like this instead of doing a git clone:

https://github.com/rbenv/rbenv/archive/585ed84283f3308380b843391ee7b12706ecff87.tar.gz

Looks like it also supports short shas (but the resulting file is the full git sha):
https://github.com/rbenv/ruby-build/archive/e9fa4bf.tar.gz

It also looks like calling that repeatedly produces a tar file with the same sha1sum so in a way that is "reproducible" and can be added to CI checks.

This would work for the given set of REPOS since they're all hosted on Github, but wouldn't work if other git hosting providers are added to that list.

@asottile
Copy link
Member

I'll rebase this on #1915 once that merges!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants