Do version numbers have to have a '.'?

[paddyroddy]

Looking at this line it looks to be testing for the presence of a dot in the version number

pre-commit/pre_commit/clientlib.py

Line 124 in d827e9a

if '.' not in rev and not re.match(r'^[a-fA-F0-9]+$', rev):

but what if a repo is just following a simple v1/v2 model?

I'm using this repo https://gitlab.salort.eu/jsalort/latexhook/-/tags which has a v1 tag. My .pre-commit-config.yaml looks like this:

repos:
    - repo: https://gitlab.salort.eu/jsalort/latexhook
      rev: v1
      hooks:
          - id: latexindent

This means every time i commit I get this error at the top

My version is pre-commit==2.10.1 and I don't think this used to happen

[paulhfischer]

thanks for the issue, you're correct this warning is new in pre-commit 2.10 (#1715) but shouldn't be triggered in your case (it's there to warn when you are pointing to master or HEAD in .pre-commit-config.yaml).

for now (until the detection is improved/updated) you could use the (short) sha the tag points to, in your case 7879fc02.

[paddyroddy]

okay cheers, that does that job

[asottile]

yeah unfortunately due to moving tags we're using a string validation for whether something looks like a mutable reference.

the other unfortunate bit is I've seen v1 / v2 be rather common moving tags so I'm not sure if this will get fixed -- if the tag becomes v1.0 it should pass the warning check

the warning is mostly intended to catch conventionally floating things like master / stable / etc.

[paddyroddy]

Could it be changed to something like

if '.' not in rev and not re.match(r'^[a-fA-F0-9]+$', rev) and not re.match('^v[0-9]+$', rev):

Thus having what you have now but also allowing i.e. v1.

[asottile]

a change like that could work but:

the other unfortunate bit is I've seen v1 / v2 be rather common moving tags

so I'm not sure if that would be a good idea.

[paddyroddy]

ah okay, sorry didn't really know what you meant by that

[asottile]

yeah so for now I'm going to answer this issue as "yes" -- we may revisit if this comes up more frequently