Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added recursive repository support for golang #1789

Merged
merged 2 commits into from Feb 6, 2021
Merged

added recursive repository support for golang #1789

merged 2 commits into from Feb 6, 2021

Conversation

paulhfischer
Copy link
Contributor

resolves #1788

note that i also added depth=1 to reduce cache size and installation time. not sure if the whole command call should be replaced with _shallow_clone, depends on whether you want to keep all command calls within the helper module or not.

@asottile
Copy link
Member

asottile commented Feb 6, 2021

oh :/ this was going to be my stream today -- this needs a test

@paulhfischer
Copy link
Contributor Author

oh i'm sorry :/

do you want to do this later today or shall i add a test?

@asottile
Copy link
Member

asottile commented Feb 6, 2021

up to you -- the test is the actually interesting part of the patch. you might as well proceed

--depth actually doesn't matter here since that directory is ephemeral, though --reference might make it faster

Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some tests with --shared and --reference and --depth=1 and they didn't make a difference in the cloned size so I'm just going to stick to the easiest command here

@asottile asottile merged commit 2dac92c into pre-commit:master Feb 6, 2021
@paulhfischer paulhfischer deleted the recursive_golang branch February 6, 2021 22:03
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

recursive submodule support for language: golang
2 participants