Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for other types of hooks #1762

Closed
psacawa opened this issue Jan 20, 2021 · 4 comments
Closed

Support for other types of hooks #1762

psacawa opened this issue Jan 20, 2021 · 4 comments

Comments

@psacawa
Copy link
Contributor

psacawa commented Jan 20, 2021

Is there are reason why only some types of hooks are supported? I am interested in the post-merge hook that checks whether any documentation source files have been changed, and rebuilds them to html and prints them if they have. I would like to run it as a post-merge hook so it runs on git pull.

The documentation suggests this is not supported. Is there a workaround? Is there a technical obstruction to this use case?

@asottile
Copy link
Member

nope! just needs someone to implement the other hooks. They've been implemented as needed

if you want to try your hand at adding one, you might want to take a look at one of the others that's been implemented

for example, here's the commit which added post-commit support: 26adf1d

@psacawa
Copy link
Contributor Author

psacawa commented Jan 20, 2021

This seems not hard, especially since post-merge is simple, so I'll try this.

@asottile
Copy link
Member

asottile commented Feb 7, 2021

@psacawa did you have a change to take a look at this?

@psacawa
Copy link
Contributor Author

psacawa commented Feb 7, 2021

Yes, however I didn't create any tests, so I didn't submit a pr: 317ac63
This is unfortunately low on my list of priorities. What's there is the easy part.

This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants