added warning if mutable rev is used #1715

paulhfischer · 2020-11-25T21:57:11Z

resolves #974

only added a warning instead of raising an error because this might break multiple projects otherwise
not sure if other mutable revs should also cause a warning, couldn't think of a way to detect them in general …
the check could also be included in the MigrateShaToRev-class, but i think it's better to keep them separated
test only checks for HEAD, this is sufficient imo, but i can also change it so it tests for all mutable revs defined in {'HEAD', 'stable', 'master'}

pre_commit/clientlib.py

tests/clientlib_test.py

pre_commit/clientlib.py

tests/clientlib_test.py

asottile

`pre-commit` don't recommend to use a mutable reference to `rev` and now shows a warning when `rev` is a mutable reference. Ref: pre-commit/pre-commit#1715

asottile reviewed Nov 26, 2020

View reviewed changes

asottile reviewed Nov 30, 2020

View reviewed changes

pre_commit/clientlib.py Outdated Show resolved Hide resolved

pre_commit/clientlib.py Outdated Show resolved Hide resolved

asottile reviewed Dec 3, 2020

View reviewed changes

asottile reviewed Dec 7, 2020

View reviewed changes

tests/clientlib_test.py Outdated Show resolved Hide resolved

added warning if mutable rev is used

1e4de98

asottile approved these changes Dec 18, 2020

View reviewed changes

asottile merged commit 0ed7930 into pre-commit:master Dec 18, 2020

paulhfischer deleted the warn_if_mutable_rev_is_used branch December 18, 2020 23:21

asottile mentioned this pull request Dec 30, 2020

Pinned versions compete at different scopes #1748

Closed

paulhfischer mentioned this pull request Feb 9, 2021

Do version numbers have to have a '.'? #1794

Closed

y-yagi mentioned this pull request Mar 29, 2021

Don't suggest a mutable reference to rev dnephin/pre-commit-golang#67

Open

alexpdp7 mentioned this pull request Nov 20, 2023

Document what pre-commit considers a mutable reference to be, or tweak the definition #3073

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added warning if mutable rev is used #1715

added warning if mutable rev is used #1715

paulhfischer commented Nov 25, 2020

asottile left a comment

Navigation Menu

added warning if mutable rev is used #1715

added warning if mutable rev is used #1715

Conversation

paulhfischer commented Nov 25, 2020

asottile left a comment

Choose a reason for hiding this comment