check cygwin mismatch earlier #1606
Merged
+33
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@asottile I tried this out, and it does move the cygwin mismatch check up earlier. I don't think it fixes the issue though, it isn't that I am missing the error because of the other issues, the problem is that I shouldn't be getting this warning at all. I am not running in cygwin, I am in MSYS2 and my git and Python aren't mismatched. |
|
they are mismatched, one is acting like windows and the other is acting like posix -- that's the entire point of the warning |
asottile
force-pushed
the
move_cygwin_mismatch
branch
from
c87d534
to
91530f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1605