Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's the best way to install pre-commit for a npm/javascript project #1439

Open
struys opened this issue May 6, 2020 · 4 comments
Open
Labels

Comments

@struys
Copy link
Contributor

struys commented May 6, 2020

Curious if there's good examples of how to best do this, I would be happy to write up docs for it.

Is the answer make it an npm package?

@struys struys added the question label May 6, 2020
@asottile
Copy link
Member

asottile commented May 7, 2020

that's a good question, I suspect we could build a package which does something similar to install-local.py but writes to node_modules/.bin or whatever?

at my last employment, even for node projects, most developers did brew install pre-commit (and developed on their laptops) -- I myself don't work on any node projects so I'd be interested to hear from others that have this set up

@asottile
Copy link
Member

in #1616 I'm making a zipapp, it's a pure-python executable zip which should be portable enough to stick into an npm package if desired

@dmwelch
Copy link

dmwelch commented Oct 8, 2021

This isn't related, right? https://www.npmjs.com/package/pre-commit

@asottile
Copy link
Member

asottile commented Oct 9, 2021

correct, entirely unrelated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants