Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement post-commit #1415

Merged
merged 1 commit into from Apr 28, 2020
Merged

Implement post-commit #1415

merged 1 commit into from Apr 28, 2020

Conversation

ModischFabrications
Copy link
Contributor

@ModischFabrications ModischFabrications commented Apr 26, 2020 •
edited by asottile

Implement post-commit as an additional git hook.

This will close #1411.

@ModischFabrications
Copy link
Contributor Author

Oh, I also added *.idea to the gitignore to prevent intellij from adding stuff that's irrelevant, feel free to remove it if it's unwanted.

@asottile
Copy link
Member

Oh, I also added *.idea to the gitignore to prevent intellij from adding stuff that's irrelevant, feel free to remove it if it's unwanted.

just a general tip for open source, you should never touch .gitignore for other people's projects

asottile
asottile reviewed Apr 26, 2020
View reviewed changes
pre_commit/commands/hook_impl.py Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
pre_commit/commands/hook_impl.py Outdated Show resolved Hide resolved
pre_commit/commands/run.py Outdated Show resolved Hide resolved
@ModischFabrications ModischFabrications marked this pull request as ready for review April 26, 2020 20:28
@ModischFabrications
Copy link
Contributor Author

ModischFabrications commented Apr 26, 2020 •
edited

Ready for review, should be mergeable.

asottile
asottile reviewed Apr 27, 2020
View reviewed changes
tests/commands/install_uninstall_test.py Outdated Show resolved Hide resolved
tests/commands/install_uninstall_test.py Outdated Show resolved Hide resolved
tests/commands/install_uninstall_test.py Outdated Show resolved Hide resolved
tests/commands/install_uninstall_test.py Outdated Show resolved Hide resolved
tests/commands/install_uninstall_test.py Outdated Show resolved Hide resolved
tests/commands/run_test.py Outdated Show resolved Hide resolved
pre_commit/commands/run.py Outdated Show resolved Hide resolved
asottile
asottile reviewed Apr 27, 2020
View reviewed changes
tests/commands/install_uninstall_test.py Outdated Show resolved Hide resolved
tests/commands/install_uninstall_test.py Outdated Show resolved Hide resolved
@ModischFabrications
Copy link
Contributor Author

alright, any last objections? I think it's done.

@asottile
Copy link
Member

also, please stop saying "it's ready to merge" or "it's done" -- it sounds very pretentious and you don't decide when it's done, the project does

@asottile asottile merged commit ec6ba99 into pre-commit:master Apr 28, 2020
@ModischFabrications ModischFabrications deleted the post_commit branch April 28, 2020 18:24
@asottile
Copy link
Member

thanks again, this has been released as part of v2.4.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asottile asottile asottile left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

allow post-commit hook
2 participants
@ModischFabrications @asottile