Detect missing arg for prepare-commit-msg and commit-msg #1341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asottile
reviewed
Feb 22, 2020
particledecay
force-pushed
the
catch_commit-msg_missing_arg
branch
from
9f217f4
to
fc8ced7
Compare
If using the prepare-commit-msg and commit-msg stages specifically (such
as with the try-repo command), the `--commit-msg-filename` arg must be
provided.
[fixes pre-commit#1336]
chore: improve error message for hook stage check
asottile
force-pushed
the
catch_commit-msg_missing_arg
branch
from
fc8ced7
to
5258dce
Compare
|
I went ahead and:
|
|
Nice... admittedly I was trying to familiarize myself with all the functions you're using in your unit tests but I just haven't had the time this weekend. |
|
no problem! patch looked good and I wanted to build on it in some other PRs which would have conflicted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If using the prepare-commit-msg and commit-msg stages specifically (such as with the try-repo command), the
--commit-msg-filenamearg must be provided.Resolves #1336