Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect NODE_PATH on win32 #1123

Closed
henryykt opened this issue Aug 27, 2019 · 2 comments
Closed

Incorrect NODE_PATH on win32 #1123

henryykt opened this issue Aug 27, 2019 · 2 comments

Comments

@henryykt
Copy link
Contributor

On win32, running the eslint pre-commit hook with additional plugin fails.

For example using this test repository:

h@pc MINGW64 ~/workspace/github/node_path-pre-commit-test (master)
$ git remote -v
origin  https://github.com/henryykt/node_path-pre-commit-test.git (fetch)
origin  https://github.com/henryykt/node_path-pre-commit-test.git (push)

h@pc MINGW64 ~/workspace/github/node_path-pre-commit-test (master)
$ pre-commit run -av
[eslint] eslint..........................................................Failed
hookid: eslint

Oops! Something went wrong! :(

ESLint: 6.2.2.

ESLint couldn't find the plugin "eslint-plugin-prettier".

(The package "eslint-plugin-prettier" was not found when loaded as a Node module from the directory "C:\Users\henryt\workspace\github\node_path-pre-commit-test".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

    npm install eslint-plugin-prettier@latest --save-dev

The plugin "eslint-plugin-prettier" was referenced from the config file in ".eslintrc.js".

If you still can't figure out the problem, please stop by https://gitter.im/eslint/eslint to chat with the team.

python version:

h@pc MINGW64 ~/workspace/github/node_path-pre-commit-test (master)
$ python -VV
Python 3.7.3 (v3.7.3:ef4ec6ed12, Mar 25 2019, 22:22:05) [MSC v.1916 64 bit (AMD64)]
@henryykt
Copy link
Contributor Author

#1122

@asottile
Copy link
Member

Thanks for the issue and fix! This has been released as 1.18.3 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants