Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust language: use the new cargo install command #1113

Merged
merged 1 commit into from
Aug 11, 2019

Conversation

zimbatm
Copy link
Contributor

@zimbatm zimbatm commented Aug 8, 2019

cargo install now requires an additional --path <TARGET> argument.

Fixes #1112

Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile
Copy link
Member

asottile commented Aug 8, 2019

E error: /tmp/pytest-of-vsts/pytest-0/test_rust_hook0/0/.pre-commit/repoy25Xd6/rustenv-default is not a directory. --path must point to a directory containing a Cargo.toml file.

hmm ok after reading the docs it seems that --path should be used when installing . essentially (and not needed otherwise) -- so I think --path . is what we want here?

@zimbatm
Copy link
Contributor Author

zimbatm commented Aug 8, 2019

I'm not sure which path is which. Let's see what the CI has to say.

@asottile
Copy link
Member

asottile commented Aug 8, 2019

well now I have no idea, maybe @chriskuehl knows better?

E               error: could not find `shellharden` in /tmp/pytest-of-vsts/pytest-0/test_additional_rust_cli_depen0/0/.pre-commit/repopsLO1P with version `=3.1.0`

cargo install now requires an additional `--path <TARGET>` argument.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

rust hook requires --path attribute
2 participants