Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added hook-stage print to output for missing hook id #1079

Merged
merged 2 commits into from
Jul 9, 2019

Conversation

zanieb
Copy link

@zanieb zanieb commented Jul 9, 2019

Adds the value of hook-stage to the error message for a missing hook id to suggest setting a different stage.

Possible additions before merging:

  • Add a prompt to set the hook-stage
  • Add a search for the id in different stages to say Did you mean to use --hook-stage bleh
  • Add tests for more than commit and push

Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@zanieb
Copy link
Author

zanieb commented Jul 9, 2019

Shame on me for not installing and running the pre-commit hooks! Should be fixed now.

@asottile
Copy link
Member

asottile commented Jul 9, 2019

Shame on me for not installing and running the pre-commit hooks! Should be fixed now.

I'm over here having a cackle 🤣

@asottile asottile merged commit 95afd64 into pre-commit:master Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants