From 2188c0fd2c4feefefe6ab7b2b45e8b4c4fa93acc Mon Sep 17 00:00:00 2001 From: Anthony Sottile Date: Wed, 30 Mar 2022 10:38:05 -0400 Subject: [PATCH] include the configured value in the language_version / additional_dependencies error --- pre_commit/languages/helpers.py | 8 +++++--- tests/languages/helpers_test.py | 4 +++- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/pre_commit/languages/helpers.py b/pre_commit/languages/helpers.py index dd219ffa1..808082665 100644 --- a/pre_commit/languages/helpers.py +++ b/pre_commit/languages/helpers.py @@ -67,7 +67,8 @@ def environment_dir(d: str | None, language_version: str) -> str | None: def assert_version_default(binary: str, version: str) -> None: if version != C.DEFAULT: raise AssertionError( - f'For now, pre-commit requires system-installed {binary}', + f'for now, pre-commit requires system-installed {binary} -- ' + f'you selected `language_version: {version}`', ) @@ -77,8 +78,9 @@ def assert_no_additional_deps( ) -> None: if additional_deps: raise AssertionError( - f'For now, pre-commit does not support ' - f'additional_dependencies for {lang}', + f'for now, pre-commit does not support ' + f'additional_dependencies for {lang} -- ' + f'you selected `additional_dependencies: {additional_deps}`', ) diff --git a/tests/languages/helpers_test.py b/tests/languages/helpers_test.py index 49d81226e..259cb97c9 100644 --- a/tests/languages/helpers_test.py +++ b/tests/languages/helpers_test.py @@ -88,7 +88,9 @@ def test_assert_no_additional_deps(): helpers.assert_no_additional_deps('lang', ['hmmm']) msg, = excinfo.value.args assert msg == ( - 'For now, pre-commit does not support additional_dependencies for lang' + 'for now, pre-commit does not support additional_dependencies for ' + 'lang -- ' + "you selected `additional_dependencies: ['hmmm']`" )