Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve message on setting exe bit for check-shebang-scripts-are-executable #770

Closed
mdeweerd opened this issue May 22, 2022 · 2 comments · Fixed by #774
Closed

Improve message on setting exe bit for check-shebang-scripts-are-executable #770

mdeweerd opened this issue May 22, 2022 · 2 comments · Fixed by #774

Comments

@mdeweerd
Copy link
Contributor

Regarding check-shebang-scripts-are-executable

The suggestion when a file is not executable and it is supposed to be is:

 FILE: has a shebang but is not marked executable!
  If it is supposed to be executable, try: `chmod +x FILE`

But chmod +x FILE is not enough in my setup, I have to do git update-index --chmod=+x FILE .

I propose to add that suggestion to output.
@asottile
Copy link
Member

please send a patch, there's an equivalent message for the other executable check that you can copy

@mdeweerd
Copy link
Contributor Author

mdeweerd commented May 26, 2022 •
edited

Ok, made PR #773 #774 where I updated both messages the message I mentionned.

@asottile asottile mentioned this issue May 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add instruction to change executable mode on windows
2 participants
@mdeweerd @asottile