Erlang extensions and files #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asottile
reviewed
Oct 27, 2022
identify/extensions.py
Outdated
| @@ -78,6 +80,7 @@ | |||
| 'hcl': {'text', 'hcl'}, | |||
| 'hh': {'text', 'header', 'c++'}, | |||
| 'hpp': {'text', 'header', 'c++'}, | |||
| 'hrl': {'text', 'header', 'erlang'}, | |||
There was a problem hiding this comment.
while the current header tag isn't great -- I think it kinda means C-like headers so this would break tools expecting those?
There was a problem hiding this comment.
I'm not 100% sure what you mean. Erlang header files usually contain macros shared between source files. Do you have an example on how it's used in c?
There was a problem hiding this comment.
it's that it's already used for c likes so reusing the tag for erlang would break existing things
There was a problem hiding this comment.
hm, ok. I've removed 'header' for now, let's see how it works and in worst case I'll add a 'header_erlang' tag or something then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most common extensions for Erlang
I also included a configuration file
rebar.configfor one of the most common compilers. The other files included aresys.configspecifying the released applications configuration andsys.config.srcfor the pre-released version.