New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Lektor extensions, additional tool config rcfiles and common plain-text meta-files lacking extensions #156
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- rebase
- fix the test that's failing
- provide links in the PR to the individual configuration formats
3521338
to
3d3da75
Compare
3d3da75
to
61147ab
Compare
Thanks for the quick review!
Done.
Not sure what you mean, all the tests were green before and are now?
Done, also updated for the changes you mentioned. |
I added a test on master -- you fixed it as part of fixing one of your two typos :) |
61147ab
to
a5197ad
Compare
a5197ad
to
2ac0455
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
KITTEH 😸 |
Meows in Spanish Maybe a little out of scope, but why not defer the request until the click event fires for the approve radio button? Seems like it would save a lot of extra requests when doing loading any PR page without approving it, especially when clueless contributors like me keep making typos, heh. Too much latency needing to wait for the request after clicking approve, or just not optimized? |
too much latency, yeah |
.lr
files from the Lektor static CMS, and.lektorproject
which == INIThere was one ambiguity here: Should ordering the
NAMES
dict be case-sensitive (i.e. should capitalized letters have higher precedence than lowercase)? Currently, this wasn't possible to infer from the existing order, as there were no cases I could find where this would have made a difference to ordering, but this PR adds one such instance (pylintrc
). I arbitrarily picked non-case-sensitive ordering for now, but I'm happy to change it if desired, just lmk. Thanks!