Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Action fails if saving cache fails #53 #54

Merged
merged 1 commit into from Apr 5, 2021

Conversation

s-weigand
Copy link
Contributor

@s-weigand s-weigand commented Oct 12, 2020

This should fix #53, but as said before, the problem itself is most likely due to corruped cache, which makes testing it quite hard.
Wrapped saving cache in try-catch block, so the action itself shouldn't fail, if the caching fails.

@asottile
Copy link
Member

one change per patch please, some parts of this are acceptable others are not -- I'm also planning to scrap/rewrite this at some point so I'm not sure if changing it now is a good idea

@s-weigand
Copy link
Contributor Author

Ok sure, does keeping 470aac6 and ec0d6c4 sound reasonable to you?

@asottile
Copy link
Member

Ok sure, does keeping 470aac6 and ec0d6c4 sound reasonable to you?

yep seems fine, want to split those out?

@s-weigand
Copy link
Contributor Author

Sure can do

index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@dhimmel
Copy link

dhimmel commented Apr 4, 2021

Have been getting Error: reserveCache failed: Cache already exists somewhat frequently, so thanks for this PR. Just wanted to check in, since would be great to avoid failing tests from non-essential caching.

@s-weigand
Copy link
Contributor Author

Didn't have that error again and forgot this PR 😅
From my side, it is ready if @asottile is fine with it.

@asottile
Copy link
Member

asottile commented Apr 4, 2021

the comments aren't addressed

@s-weigand
Copy link
Contributor Author

@asottile Should be fine now... I hope 😅

index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile asottile merged commit 8ac8946 into pre-commit:master Apr 5, 2021
@s-weigand s-weigand deleted the fix-53 branch April 5, 2021 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Action fails if saving cache fails
3 participants