Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action version updates - not duplicate #197

Closed
ulgens opened this issue Mar 10, 2024 · 5 comments
Closed

Action version updates - not duplicate #197

ulgens opened this issue Mar 10, 2024 · 5 comments

Comments

@ulgens
Copy link

ulgens commented Mar 10, 2024

I found multiple issues / PR about action version updates. These are got closed because they are duplicates:

This is not the newest one; I think this was the one being referred to as the original for some:

but, it got closed too. In the end, that update is still not merged.

@asottile I can create a new PR or we can open #188 back.

@asottile
Copy link
Member

read the room

@ulgens
Copy link
Author

ulgens commented Mar 11, 2024

@asottile Can you please explain what you mean? The tool is not dead; thousands of projects are still using it, and the only alternative recommended by it is the commercial version itself, which doesn't solve the need if you are just looking for a simple way to run pre-commit without any additional tool or service. And the readme says it's in maintenance mode, but any attempt for maintenance gets rejected for no clear reason for a while.

I'm not coming here and yelling "WHY DON'T YOU RELESAE ANYTHING!?". There is a clear opportunity to improve, and people are willing to help with it. I think this calls for clearer conversation compared to "read the room" or "go search" (for sth that doesn't exist anymore).

@asottile
Copy link
Member

you seem to be so upset that you missed #190 ?

@ulgens
Copy link
Author

ulgens commented Mar 11, 2024

@asottile I don't see anything to be upset about, but I agree that this communication would have been more effective. Thanks for the link and your time.

I didn't miss it. It doesn't cover all proposed changes from the rest of the discussion, so I was thinking there should be another PR to cover the rest. I can still do that if you think it's fine, or we can leave it there as is.

@asottile
Copy link
Member

please don't

@pre-commit pre-commit locked as off-topic and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants