This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
fix: Update to GO 1.18 so scan works on new projects #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would also need this fix. |
|
@isp1r0 @praetorian-harry Hey sorry to ping, just curious if we can merge this so gokart works with new go projects |
|
@ynsta @adadkins the go team recently announced https://go.dev/blog/vuln |
|
@sc-atompower thanks for that, i did not see that announcement. I'm gong to close this PR and switch to using that. Thanks |
It's not even the same thing. GoKart is a static code analyser. GoVulnCheck is for dependency vulnerability management. This issue should be reopened. |
|
Reopening |
praetorian-thendrickson
added a commit
that referenced
this pull request
Sep 19, 2022
This reverts commit 059d22f.
praetorian-harry
pushed a commit
that referenced
this pull request
Sep 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you run
gokart scanon go 1.18 projects, you get an error:internal error: package "time" without types was imported from "github.com/Omaze/cl-sweeps-api/internal/common"We need to have a 1.18 build for gokart for it to work with new go projects