Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

Comparism with CodeQL #11

Open
thediveo opened this issue Aug 19, 2021 · 4 comments
Open

Comparism with CodeQL #11

thediveo opened this issue Aug 19, 2021 · 4 comments
Labels
documentation Improvements or additions to documentation

Comments

@thediveo
Copy link

Would it be possible to compare gokart with CodeQL, at least on some ballpark figure? For instance, can gokart detect problems with int conversions between different sizes, et cetera? For instance, CodeQL is very helpful at catching such things.

And finally, the obvious question: does gokart detect race conditions?

@praetorian-harry praetorian-harry added the documentation Improvements or additions to documentation label Aug 20, 2021
@thediveo
Copy link
Author

To give an example: CodeQL finds "Incorrect conversion of an integer with architecture-dependent bit size from to a lower bit size type int32 without an upper bound check."

@praetorian-harry
Copy link
Collaborator

@thediveo "does gokart detect race conditions?" 😂 Despite the suitability of such a vulnerability check with the tool name, GoKart does not currently detect race conditions. Maybe soon!

Thank you for the issue submission and the example given. We are taking a look at the golang queries defined here and here. At a glance, we believe that CodeQL has broader coverage than what we would typically report as actionable, important security issues. We plan to perform a more thorough analysis to determine if there are other useful security checks that CodeQL covers that would be a fit for GoKart and are currently missing.

Are there other examples of CodeQL security checks that you believe would be important to support with GoKart?

@thediveo
Copy link
Author

No more ideas at the moment, the CWE-681 is one that seems to be quite fond of me, unfortunately, when working on system-level Go tools.

@thediveo
Copy link
Author

+CWE-190

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Development

No branches or pull requests

2 participants