Broken with Sphinx 7.1.0 on Windows

[henryiii]

The Sphinx 7.1.0 release yesterday breaks Furo on Windows; css_tag(css) is causing a file to be attempted to be opened with ?digest=e6660623a769aa55fea372102b9bf3151b292993 added to it, which of course breaks.

  File "D:\a\scikit-build-core\scikit-build-core\.nox\docs\Lib\site-packages\furo\theme\furo\base.html", line 62, in block 'regular_styles'
    {{ css_tag(css) }}
  File "D:\a\scikit-build-core\scikit-build-core\.nox\docs\Lib\site-packages\jinja2\sandbox.py", line 393, in call
    return __context.call(__obj, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\a\scikit-build-core\scikit-build-core\.nox\docs\Lib\site-packages\sphinx\builders\html\__init__.py", line 1202, in css_tag
    if checksum := _file_checksum(app.outdir, css.filename):
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\a\scikit-build-core\scikit-build-core\.nox\docs\Lib\site-packages\sphinx\builders\html\__init__.py", line 1254, in _file_checksum
    with open(path.join(outdir, filename), encoding='utf-8') as f:
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
OSError: [Errno 22] Invalid argument: 'D:\\a\\scikit-build-core\\scikit-build-core\\docs\\_build\\html\\_static/styles/furo.css?digest=e6660623a769aa55fea372102b9bf3151b292993'

Seen in scikit-build/scikit-build-core#440 and scikit-build/scikit-build-core#441. I opened an issue with sphinx, sphinx-doc/sphinx#11518, but this was considered an issue with Furo and not something Sphinx would fix. I think it's this is the unsupported code:

furo/src/furo/__init__.py

Lines 149 to 153 in f8db95b

	@lru_cache(maxsize=None)
	def _asset_hash(path: str) -> str:
	"""Append a `?digest=` to an url based on the file content."""
	full_path = THEME_PATH / "static" / path
	digest = hashlib.sha1(full_path.read_bytes()).hexdigest()

[AA-Turner]

Furo could gate the asset hashes code on if the Sphinx version is 7.0 or earlier, which I believe would solve the problem?

A

[henryiii]

Don’t you mean 7.1? But that’s what I was thinking might be an easy fix. Not that I know much about it, though.

[pradyunsg]

@AA-Turner The relevant change was added in Sphinx 7.1 -- sphinx-doc/sphinx#11415 -- so I've used 7.1 as the constraint.

Please do let me know if there's something missing here!

[AA-Turner]

That's right! I was a little unclear, I intended to say that Furo's own logic would only be applied if the Sphinx version was 7.0.* or earlier -- the opposite of which is disabling if greater than or equal to 7.1!

A

[pradyunsg]

Was definitely an issue!

Fixed in https://pradyunsg.me/furo/changelog/#vigilant-volt (https://github.com/pradyunsg/furo/releases/tag/2023.07.26, a92dd0c is the fix).