Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent commits that violates quality standards using git hooks (Husky) #24

Open
goldbergyoni opened this issue Mar 29, 2022 · 0 comments 路 May be fixed by #174
Open

Prevent commits that violates quality standards using git hooks (Husky) #24

goldbergyoni opened this issue Mar 29, 2022 · 0 comments 路 May be fixed by #174
Assignees
@kalitas @idobetesh
Labels
enhancement New feature or request good first issue Good for newcomers less-than-30-minutes non-blocking You may claim this and process slowly over time, it doesn't the critical path
Milestone
machine

Comments

@goldbergyoni
Copy link
Contributor

goldbergyoni commented Mar 29, 2022 •
edited

馃幆 Goal: As a developer, I will not mistakenly send code with linting/testing/CVE issues

馃 Requirements:

  • Configure GitHook that runs all quality tools and stops the commit upon failure. Husky is quite popular tool for this mission
  • Put in both the generator project (root) and the generated app (code templates)
  • Allow by-pass, we always have CI as last the safety net
  • Make it active on developers machine automatically as they 'npm install' their code
  • For now, we have tests only, so husky should ensure that 'npm test' passes. Feel free to configure linter
@goldbergyoni goldbergyoni added enhancement New feature or request good first issue Good for newcomers less-than-30-minutes labels Mar 29, 2022
@goldbergyoni goldbergyoni added this to the machine milestone Mar 31, 2022
@kalitas kalitas self-assigned this Apr 11, 2022
@goldbergyoni goldbergyoni added the non-blocking You may claim this and process slowly over time, it doesn't the critical path label May 8, 2022
@idobetesh idobetesh self-assigned this Jul 7, 2022
@idobetesh idobetesh pinned this issue Jul 7, 2022
@idobetesh idobetesh unpinned this issue Jul 7, 2022
@idobetesh idobetesh linked a pull request Jul 7, 2022 that will close this issue
Add husky for pre commit hooks 馃惗 #174
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kalitas kalitas

@idobetesh idobetesh

Labels
enhancement New feature or request good first issue Good for newcomers less-than-30-minutes non-blocking You may claim this and process slowly over time, it doesn't the critical path
Projects
None yet
Milestone
machine
Development

Successfully merging a pull request may close this issue.

Add husky for pre commit hooks 馃惗 practicajs/practica
3 participants
@kalitas @goldbergyoni @idobetesh