Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add joystick/gamepad deadzone setting #17942

Merged
merged 8 commits into from
Apr 24, 2022
Merged

Add joystick/gamepad deadzone setting #17942

merged 8 commits into from
Apr 24, 2022
+88 −5

Conversation

maromalo
Copy link
Contributor

@maromalo maromalo commented Apr 23, 2022 •
edited by peppy
Loading

Adds a joystick subsection and deadzone configuration.

Sorry, something went wrong.

maromalo added 2 commits April 23, 2022 00:17
@maromalo
Add joystick/gamepad deadzone setting
27f3499 
Also splits joystick/gamepad into a new sub-section.
@maromalo
Merge branch 'ppy:master' into master

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
85c47e1
@peppy
Copy link
Member

peppy commented Apr 23, 2022

Please make sure to read the contribution guidelines and use a non-master branch in the future.

@maromalo
Code Quality
23ef1e1 
Whoops.
@pull-request-size pull-request-size bot added size/L and removed size/M labels Apr 23, 2022
@maromalo
More Code Quality
6a87dfd 
Double whoops.
@maromalo @frenzibyte
Change JoystickSettingsStrings.cs text

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
0133ee9 
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
bdach
bdach reviewed Apr 23, 2022
View reviewed changes
Copy link
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to mostly work in testing, just one doubt re: how the setting is specified

bdach
bdach previously approved these changes Apr 23, 2022
View reviewed changes
@bdach bdach requested a review from peppy April 23, 2022 19:00
@pull-request-size pull-request-size bot added size/M and removed size/L labels Apr 24, 2022
@peppy peppy enabled auto-merge April 24, 2022 07:32
@peppy peppy disabled auto-merge April 24, 2022 08:39
@peppy peppy merged commit 176d263 into ppy:master Apr 24, 2022
@maromalo maromalo mentioned this pull request May 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenzibyte frenzibyte

@peppy peppy

@bdach bdach

Assignees
No one assigned
Labels
area:settings size/M type:input
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maromalo @peppy @bdach @frenzibyte