Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the dependency of k8s.io/apimachinery #615

Closed
mkumatag opened this issue May 16, 2024 · 1 comment · Fixed by #617
Closed

Remove the dependency of k8s.io/apimachinery #615

mkumatag opened this issue May 16, 2024 · 1 comment · Fixed by #617
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@mkumatag
Copy link
Member

mkumatag commented May 16, 2024

What happened:

k8s.io/apimachinery is used only for the wait.PollImmediate which can be avoid, lets use any alternative available.

ref: https://github.com/ppc64le-cloud/pvsadm/blob/b0ad45b6f6c71c8c4fb9733644f472673dd46b77/cmd/image/import/import.go#L192C14-L192C32

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • pvsadm version (use pvsadm version):
  • Environment - On-Prem or IBM PowerVS:
  • OS (e.g: cat /etc/os-release):
  • Kernel (e.g. uname -a):
  • Others:
@mkumatag mkumatag added the kind/bug Categorizes issue or PR as related to a bug. label May 16, 2024
@mkumatag mkumatag changed the title Remove the depen Remove the dependency of k8s.io/apimachinery May 16, 2024
@kishen-v
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants