Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate bluemix-go and clean-up code. #612

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Deprecate bluemix-go and clean-up code. #612

wants to merge 2 commits into from

Conversation

kishen-v
Copy link
Contributor

@kishen-v kishen-v commented May 13, 2024 •
edited

Fixes: #496, #609.

Note: The changes are done, a quick round of testing across all sub-commands is in-progress.

get:
  • cloud-connections List the existing cloud connections in the account
  • events Get Powervs events
  • per-availability List regions that support PER
  • ports Get PowerVS network ports
delete:
  • port Delete PowerVS network port
create:
  • port Create PowerVS network port
purge:
  • images Purge the powervs images
  • keys Delete PowerVS ssh key/keys
  • networks Purge the powervs networks
  • vms Purge the powervs vms
  • volumes Purge the powervs volumes
dhcpserver
  • create Create DHCP Server
  • delete Delete DHCP Server
  • get Get DHCP Server
  • list Get PowerVS DHCP servers
image
  • import Import the image into PowerVS instances
  • info Provide info about the image
  • qcow2ova Convert the qcow2 image to ova format
  • sync Sync images between IBM COS buckets
  • upload Upload the image to the IBM COS

What wasn't tested:
Testing in the test environment - https://test.cloud.ibm.com/login

@ppc64le-cloud-bot ppc64le-cloud-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 13, 2024
@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kishen-v
Once this PR has been reviewed and has the lgtm label, please assign mkumatag for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label May 13, 2024
@kishen-v kishen-v marked this pull request as draft May 14, 2024 05:03
@ppc64le-cloud-bot ppc64le-cloud-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 16, 2024
@kishen-v kishen-v changed the title [WIP] Deprecate bluemix-go and clean-up code. Deprecate bluemix-go and clean-up code. May 16, 2024
@kishen-v kishen-v marked this pull request as ready for review May 16, 2024 16:46
@ppc64le-cloud-bot ppc64le-cloud-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 16, 2024
@kishen-v
Copy link
Contributor Author

cc: @Karthik-K-N.

Karthik-K-N
Karthik-K-N reviewed May 20, 2024
View reviewed changes
Copy link
Contributor

@Karthik-K-N Karthik-K-N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initial review, Will take a look again later.

cmd/get/cloudconnections/cloudconnections.go Show resolved Hide resolved
cmd/get/cloudconnections/cloudconnections.go Show resolved Hide resolved
cmd/image/import/import.go Show resolved Hide resolved
cmd/image/import/import.go Show resolved Hide resolved
cmd/image/import/import.go Show resolved Hide resolved
cmd/image/import/import.go Show resolved Hide resolved
cmd/image/upload/upload.go Outdated Show resolved Hide resolved
pkg/client/client.go Show resolved Hide resolved
@mkumatag
Copy link
Member

mkumatag commented Jun 7, 2024

@kishen-v it will be great if you can divide this PR into two, one for deprecating and another for cleanup..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karthik-K-N Karthik-K-N Karthik-K-N left review comments

@Rajalakshmi-Girish Rajalakshmi-Girish Awaiting requested review from Rajalakshmi-Girish

@sudeeshjohn sudeeshjohn Awaiting requested review from sudeeshjohn

Assignees
No one assigned
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove dependency - https://github.com/IBM-Cloud/bluemix-go
4 participants
@kishen-v @ppc64le-cloud-bot @mkumatag @Karthik-K-N