Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated github.com/AlecAivazis/survey/v2 with charmingbracelet/huh. #561

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

kishen-v
Copy link
Contributor

@kishen-v kishen-v commented Feb 22, 2024

Fixes: #495

This PR addresses #495.
Confirmatory prompt:
Pasted Graphic 2
Selection menu from charmingbracelet/huh:
Pasted Graphic
User Input:
Pasted Graphic

@ppc64le-cloud-bot ppc64le-cloud-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 22, 2024
@kishen-v
Copy link
Contributor Author

kishen-v commented Feb 26, 2024

Switched to a better way of choosing confirmatory prompts.
image

Expected behaviour is observed
image

@kishen-v kishen-v force-pushed the remove-deps branch 2 times, most recently from 6e4fedf to 8a73710 Compare February 26, 2024 05:31
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot ppc64le-cloud-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 26, 2024
@mkumatag mkumatag added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Feb 26, 2024
@ppc64le-cloud-bot ppc64le-cloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2024
@mkumatag
Copy link
Member

@kishen-v can you please rebase this PR?

Unify modules of same functionality
@kishen-v
Copy link
Contributor Author

Hi @mkumatag, I have rebased changes over latest master.
Thanks!

Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot ppc64le-cloud-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2024
@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishen-v, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot merged commit 553a4fd into ppc64le-cloud:main Feb 28, 2024
5 checks passed
@kishen-v kishen-v deleted the remove-deps branch April 16, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove github.com/AlecAivazis/survey/v2 deps
3 participants