Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PowerMockIgnorePackagesExtractorImpl should visit interfaces ? #772

Closed
hypnoce opened this issue Mar 29, 2017 · 0 comments
Closed

PowerMockIgnorePackagesExtractorImpl should visit interfaces ? #772

hypnoce opened this issue Mar 29, 2017 · 0 comments
Labels
bug
Milestone
PowerMock 1.7.0

Comments

@hypnoce
Copy link
Contributor

hypnoce commented Mar 29, 2017 •
edited by thekingn0thing

I'm trying to share a common list of ignored package using PowerMockIgnore.
I created an empty interface annotated with PowerMockIgnore. Then, I just simply implemented the interface where I need this configuration.

But PowerMockIgnorePackagesExtractorImpl only visits super class (not the interfaces) for PowerMockIgnore annotation.

Is there another way of achieving my goal or I can do a pull request to add this feature.

Thanks

--
Francois
hypnoce added a commit to hypnoce/powermock that referenced this issue Apr 10, 2017
@hypnoce
Fixes powermock#772. Do a DFS on superclass + interfaces hierarchy to…
0acc720 
… find all PowerMockIgnore annotations. Avoid duplication introduced by diamond interface hierarchies by storing results in a set.
@thekingn0thing thekingn0thing added this to the PowerMock 1.7.0 milestone Apr 14, 2017
@hypnoce hypnoce mentioned this issue Apr 15, 2017
Merged
thekingn0thing pushed a commit that referenced this issue May 27, 2017
@hypnoce @thekingn0thing
Fixes #772. Do a DFS on superclass + interfaces hierarchy to find all…
4432467 
… PowerMockIgnore annotations. Avoid duplication introduced by diamond interface hierarchies by storing results in a set. (#777)
thekingn0thing pushed a commit that referenced this issue May 27, 2017
Fix issue #772: PowerMockIgnorePackagesExtractorImpl should visit int…
28a4f63 
…erfaces.

Fix review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
PowerMock 1.7.0
Development

No branches or pull requests
2 participants
@hypnoce @thekingn0thing