Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E-mail validation doesn't accept addresses with unicode (RFC 6531) #253

Closed
danschultzer opened this issue Aug 20, 2019 · 0 comments · Fixed by #257
Closed

E-mail validation doesn't accept addresses with unicode (RFC 6531) #253

danschultzer opened this issue Aug 20, 2019 · 0 comments · Fixed by #257
Labels
enhancement New feature or request

Comments

@danschultzer
Copy link
Collaborator

danschultzer commented Aug 20, 2019

Unicode e-mail addresses such as 你好@example.com and test@莎士比亚.org are valid, but due to the e-mail validation only being RFC 5332 compliant they can't be used with the default Pow.Ecto changeset.

Making the validation RFC 6531 compliant would solve this, but I'm pretty sure that RegExp can't be used for it. There was an issue on the W3C HTML5 specs where they went into the specifics. Also, it seems like several browsers still don't support the standard.

I'll check how other large OSS projects handles this, and figure out what would be the most straight forward approach to solve this.

Edit: The isemail npm package had a PR back in 2017 for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant