Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types for an Input.error() #1811

Merged
merged 1 commit into from Jan 6, 2023
Merged

Add types for an Input.error() #1811

merged 1 commit into from Jan 6, 2023

Conversation

hudochenkov
Copy link
Contributor

Something I found when was developing postcss-styled-syntax.

I didn't find a good way to test if types are correct.

@ai
Copy link
Member

ai commented Jan 5, 2023

Will look and take tomorrow

@ai ai merged commit 4ad96d1 into postcss:main Jan 6, 2023
@ai
Copy link
Member

ai commented Jan 6, 2023

I fixed types a little c9bd445

@ai
Copy link
Member

ai commented Jan 6, 2023

Thanks. Released in 8.4.21.

@hudochenkov hudochenkov deleted the fix-input-types branch January 7, 2023 00:58
@hudochenkov
Copy link
Contributor Author

Thanks!

How do you test all types in PostCSS? check-dts doesn't catch all of them. And there is nothing like tsconfig with allowJs.

@ai
Copy link
Member

ai commented Jan 7, 2023

How do you test all types in PostCSS?

By writing tests in TS (not case for this method, since it is not really “public”, most users should use Node#error())

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hudochenkov @ai