Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Node#warn() return type #1722

Merged
merged 1 commit into from Feb 24, 2022
Merged

Fix Node#warn() return type #1722

merged 1 commit into from Feb 24, 2022

Conversation

ybiquitous
Copy link
Contributor

I think Node#warn() should return Warning, not void:

postcss/lib/node.js

Lines 70 to 74 in 8718e06

warn(result, text, opts) {
let data = { node: this }
for (let i in opts) data[i] = opts[i]
return result.warn(text, data)
}

@ai
Copy link
Member

ai commented Feb 24, 2022

LGTM.

I will try to merge it and release when I will be back from anti-war protest.

@ybiquitous
Copy link
Contributor Author

Thank you! 😊

@ai ai merged commit 0e56894 into postcss:main Feb 24, 2022
@ai
Copy link
Member

ai commented Feb 24, 2022

Thanks for the fix. Released in 8.4.7.

@ybiquitous ybiquitous deleted the fix-node-warn-return-type branch February 24, 2022 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants