Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove comment cleaning from declaration value and at-rule parameters in PostCSS 9.0 #1706

Open
ai opened this issue Jan 28, 2022 · 2 comments
Open

Remove comment cleaning from declaration value and at-rule parameters in PostCSS 9.0 #1706

ai opened this issue Jan 28, 2022 · 2 comments
Labels
refactoring

Comments

@ai
Copy link
Member

ai commented Jan 28, 2022 •
edited

Right now, AtRule#params and Declaration#value have no comments (but comments will be preserved on no changes to value/params).

Let’s remove this logic.
@ai ai added the refactoring label Jan 28, 2022
@Martins100-Tmd
Copy link

Do you mean to clear the whole comments away??

@ai
Copy link
Member Author

ai commented Jan 18, 2024

Do you mean to clear the whole comments away??

If some PostCSS plugin change declaration’s value or at-rule params, the comment will be removed.

It doesn’t affect comments between declarations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ai @Martins100-Tmd