Remove source-map from browser build #1571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Do you have Twitter account to mention you in release tweet? |
|
No Twitter. maybe I should open one |
|
Thanks. Released in 8.2.14. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
pathis false in browsers build thesource-mappackage is actually not in use*.This PR adds
"source-map": falseto thepackage.jsonalso added explicit protection for the existence of thesource-mapAPI's.Now if one will want to use postcss in browser and support source maps he will need to include
pathandsource-mappackagesThis will decreased the bundle size of postcss by ~27% (from 29KB to 21KB)
(*) There is only one feature that I wasn't sure what to do with related to
fromJSON. It is using thePreviousMap(no problem there) andPreviousMapuses thesource-mappackage and I wasn't sure how to fallback. It might be a super edge case for browsers.